Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use themes' definitions to render the initial view. #4939

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5eedbb5 from #4936.

…loading screen font and colors. (#4936)

Signed-off-by: Miki <[email protected]>
(cherry picked from commit 5eedbb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4939 (175ebde) into 2.x (6deddde) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##              2.x    #4939   +/-   ##
=======================================
  Coverage   66.43%   66.44%           
=======================================
  Files        3398     3399    +1     
  Lines       64873    64881    +8     
  Branches    10359    10360    +1     
=======================================
+ Hits        43101    43107    +6     
- Misses      19213    19215    +2     
  Partials     2559     2559           
Flag Coverage Δ
Linux_1 34.91% <ø> (ø)
Linux_2 55.19% <83.33%> (+<0.01%) ⬆️
Linux_3 44.20% <33.33%> (-0.01%) ⬇️
Linux_4 35.09% <33.33%> (+<0.01%) ⬆️
Windows_1 34.92% <ø> (ø)
Windows_2 55.15% <83.33%> (+<0.01%) ⬆️
Windows_3 44.20% <33.33%> (-0.01%) ⬇️
Windows_4 35.09% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-ui-shared-deps/theme.ts 41.66% <ø> (ø)
src/core/server/rendering/views/fonts.tsx 100.00% <ø> (ø)
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
src/core/server/rendering/views/theme.ts 77.77% <77.77%> (ø)
src/core/server/rendering/views/styles.tsx 100.00% <100.00%> (ø)

@joshuarrrr joshuarrrr merged commit 1d2987f into 2.x Sep 6, 2023
@github-actions github-actions bot deleted the backport/backport-4936-to-2.x branch September 6, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants